[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] [PATCH] error message in Jabber vCard dialog
From:       Pino Toscano <pino () kde ! org>
Date:       2008-09-08 8:09:03
Message-ID: 200809081009.09237.pino () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hello,

currently, when opening the vCard dialog of a Jabber contact and anything 
different than the "vCard is available" situation happen, an error message 
appears.
Although, in some situation the IQ reply sent is valid, but just there is no 
vCard available. libiris already marks this situation in a different way, so 
the attached patch make use of that and presents a (better) message to the 
user.
(Also, it splits the generic error message in two lines, so it does not 
expands horizontally way too much.)

Comments?

-- 
Pino Toscano

["kopete-jabber-vcard.diff" (text/x-diff)]

Index: ui/dlgjabbervcard.cpp
===================================================================
--- ui/dlgjabbervcard.cpp	(revisione 858346)
+++ ui/dlgjabbervcard.cpp	(copia locale)
@@ -466,7 +466,10 @@
 	}
 	else
 	{
-		m_mainWidget->lblStatus->setText( i18n("Error: vCard could not be fetched \
correctly. Check connectivity with the Jabber server.") ); +		if ( \
vCard->statusCode() == ( XMPP::Task::ErrDisc + 1 ) ) \
+			m_mainWidget->lblStatus->setText( i18n("No vCard available.") ); +		else
+			m_mainWidget->lblStatus->setText( i18n("Error: vCard could not be fetched \
correctly.\nCheck connectivity with the Jabber server.") );  //it is maybe possible \
to anyway edit our own vCard (if it is new  if(m_account->myself() == m_contact)
 			setEnabled( true );


["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]