[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Bug in the msn protocol
From:       "Jose Carlos Norte" <jose () eyeos ! org>
Date:       2008-09-07 1:27:46
Message-ID: 23a91a6b0809061827o5a4f55f1i697e37edcbf1c2da () mail ! gmail ! com
[Download RAW message or body]

Ok!

Done, debug output that prints the headers removed and regexp case insensitive.

2008/9/7 Matt Rogers <mattr@kde.org>:
>
> On Sep 6, 2008, at 12:58 PM, Jose Carlos Norte wrote:
>
>> Today I have compiled the last kopete from trunk, and the msn protocol
>> was broken.
>>
>> After some research, I have found that kioslave http was not sending
>> the http headers, due to a modification in the kioslave.
>>
>> After getting this patched by ahartmetz (maelcum), I noticed that
>> still don't logs into the msn network.
>>
>> So I noticed that the protocol have changed a bit, please test this
>> patch in: kdenetwork/kopete/protocols/msn/msnsecureloginhandler.cpp
>>
>> with the LAST kdelibs from trunk, to see if your kopete is able to
>> login against msn:
>>
>> @@ -55,9 +55,9 @@
>>        {
>>                // Retrive the HTTP header
>>                QString httpHeaders =
>> loginJob->queryMetaData("HTTP-Headers");
>> -
>> +               kDebug() << httpHeaders;
>>                // Get the login URL using QRegExp
>> -               QRegExp rx("PassportURLs:
>> DARealm=(.*),DALogin=(.*),DAReg=");
>> +               QRegExp rx("passporturls:
>> DARealm=(.*),DALogin=(.*),DAReg=");
>>                rx.indexIn(httpHeaders);
>>
>>                // Set the loginUrl and loginServer
>>
>> Thanks.
>
> A few things:
> 1. Remove the debug output that prints the headers.
> 2. Can you make that regexp case-insensitive, just in case they decide to go
> back to the old way?
> 3. Attach the patch to your email. This makes it easier to apply.
>
> Thanks
> --
> Matt
>

["msnsecureloginhandler.patch" (text/x-diff)]

Index: msnsecureloginhandler.cpp
===================================================================
--- msnsecureloginhandler.cpp	(revisión: 857867)
+++ msnsecureloginhandler.cpp	(copia de trabajo)
@@ -58,6 +58,7 @@
 
 		// Get the login URL using QRegExp
 		QRegExp rx("PassportURLs: DARealm=(.*),DALogin=(.*),DAReg=");
+		rx.setCaseSensitivity(Qt::CaseInsensitive);
 		rx.indexIn(httpHeaders);
 
 		// Set the loginUrl and loginServer


_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]