[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Fix the gadu plugin set description
From:       Matt Rogers <mattr () kde ! org>
Date:       2008-08-27 23:24:01
Message-ID: 7349221E-D1B9-4CE3-A261-E2438B03B791 () kde ! org
[Download RAW message or body]


On Aug 27, 2008, at 4:26 PM, Jakub Grandys wrote:

> Tuesday 26 of August 2008 22:17:13 napisałeś(-łaś):
>> Unfortunately I didn't have any other idea to fix this
> I think this time I've found better solution ;) It also fixes crash  
> when user
> tries to set description when gadu account is offline, now it works  
> well.
> Moreover I also tried to get rid off old Qt3 classes in gaduaway.ui.  
> So instead
> of Q3ButtonGroup I've used QButtonGroup and set button's ids using
> QButtonGroup capabilities. So please send any comments regarding  
> this because
> this is my first patch. Thanks



you don't need to delete statusGroup in the destructor because you  
gave it a parent in the destructor. It will be deleted when its parent  
goes away. Other than that, looks fine, so fix that one small issue  
and I'll commit it to SVN
--
Matt

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread]