[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Incoming file transfer in chat window v2
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2008-08-25 19:20:48
Message-ID: 200808252120.52773.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le dimanche 24 août 2008, Roman Jarosz a écrit  :
> Hi,
>
> here's next version of my patch.
>
> Changes since last version
> * disabled javascript as many people don't like it to be enabled.
> * added unique id into Message class which is also used for file transfer
> id. * file transfer information in Messages are stored in separate objects
> so we don't waste memory
> * if protocol doesn't specify icon we show icon for current file extension.
> * use Kopete default font for buttons
> * some cleanups and fixes
>
> http://kedge.wz.cz/kopete/kopeteft4.png

Hi, I'm happy with the patch, it's almost good.

Last problem:
-	setOnlyLocalReferences( true );
Why exactly do you need to enable network reference?

Again you have security issue  (presence leak in that case, ...)

Otherwise i have to say the patch is very cool.

> If we want to support Adium file transfer chat styles we have to use
> javascript so i'm starting a pool :)

Why exactly? Do they have javascript embedded?
What is the javascript for?
Maybe this should be fixed in adium too.

> 1. Should we add option into Kopete config dialog (as Michal suggested) to
>    allow users to turn on javascript and use Adium ft styles

We could eventually show a warning message box when loading an adium style. 
(can we detect them?) with an option to enable it.

> 2. Do we want to use only non javascript ft styles which means
>    <form action="..."><input type="submit"></form> or <a href="..."></a>.




["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]