[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Incoming file transfer in chat window
From:       Matt Rogers <mattr () kde ! org>
Date:       2008-08-16 1:15:28
Message-ID: 6606FC52-40D8-4384-A9A9-F6FB68FC2647 () kde ! org
[Download RAW message or body]


On Aug 15, 2008, at 4:53 PM, Roman Jarosz wrote:

> Hi
>
> I've removed the ugly dialog which is shown when we got file transfer
> request and moved it into the chat window.
>
> It's based on Adium chat style (FileTransferRequest.html) although  
> to make
> it more user friendly I had to add four new keywords %fileSize%,
> %saveFileHandlerId%, %saveFileAsHandlerId%, %cancelRequestHandlerId%.
> The three id keywords are used to disable buttons after file transfer
> is accepted or rejected.
>
> If current style doesn't have FileTransferRequest.html Kopete creates
> default one based on current chat style.
>
> Here are screenshots:
> http://kedge.wz.cz/kopete/kopeteft1.png
> http://kedge.wz.cz/kopete/kopeteft2.png
> http://kedge.wz.cz/kopete/kopeteft3.png
>
> Any comments or suggestions?
>
> Regards,
> Roman
>
> PS. Currently there is a bug in khtml which paints disabled buttons  
> as active.
> I've already reported this bug. Also there was a bug which has sent  
> click events
> even if the button was disabled this bug is already fixed since  
> revision 846734.
> Oh and also button accelerators don't work yet also reported to  
> khtml guys.

Do they have to be buttons by default? I think it might look nicer to  
make them links instead.

Other than that little possibility, it looks great!
--
Matt

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]