[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] patch
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2008-07-31 17:34:51
Message-ID: 200807311935.16059.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi, 
Please send the reply to the list.

Le mardi 29 juillet 2008, vous avez écrit  :
>  >maxValue() is deprecated, please use maximum() instead.
>
> No such member method is known to me or to compiler (we talk about Qt3).

Ah, But KDE3 is old :-)  we are now working on KDE4 

>  >But i don't really understand that patch. Why does it works?
>  >I'm also afraid it can led to a kind of infinite loop if you open an
>
> I attached longer explanation.
> For me there is no infinite loop. Infinite loop is:
>
> for (int i = 0 ; ; i++);
>
> or
>
> while (true);
>
> and it takes a lot of CPU time. If chat history is empty slotScroll is
> called every 1 ms
> so it doesn't overload CPU and it doesn't consume more and more memory
> because there is no recursion.

This will still force the CPU to week up each every ms, so this is very bad if 
the laptop is running on battery.


also i don't really like the patch.  can't you make sure that the 
slotScrollView is only called after the event loop has executed all the 
geometry things?

-- 
Olivier

["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]