[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Lid auto away
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2008-04-22 20:01:28
Message-ID: 200804222201.34243.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le mardi 22 avril 2008, Martijn Klingens a écrit :
> On Saturday 19 April 2008 20:29:03 Roman Jarosz wrote:
> > Any comments before I commit it?
>
> This forces the status on return to Online. Instead, you should restore the
> previous status, whatever it was (especially if it was a manual Away, or Do
> Not Disturb and/or it had a status message set).
>
> Also, do you want to override DnD or Invisible with Away?

I don't think the patch change the current behaviour, which was correct
(ie only set away accounts that were Online)

I just wonder what the d->autoAcounts.clear() are for.

> Last, I agree with Michal that if you simply lock the screen on lid close
> you get this feature for free. You probably want that anyway, since a blank
> screen avoids wasting cpu cycles on screen updates and thus is better for
> your battery. With that in mind I think this feature belongs in an external
> DBUS script or a plugin, but not libkopete.

At least, I think it should be moved in Kopete::IdleTimer
(But I would say the feature is not that great to have in libkopte either, 
althought i'm not strongly opposed to it)

["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]