[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Non-intrusive notifications v3
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2008-03-17 20:59:43
Message-ID: 200803172159.51980.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

Thanks for the patch.


Le dimanche 16 mars 2008, Roman Jarosz a écrit  :
> Hi
>
> Here is the final version of non-intrusive notifications.
>
> Since last version I have added KNotification for new info events
> (the KNotification name is "Service Message") 

We probably want different event for eatch type of event :-)

> and made some slight 
> adjustment to the API. I've also fixed couple bug and polished the gui.
>
> All protocols are now converted to the new API, I didn't test the Yahoo,
> MSN and Telepaty but it should be ok. If anybody can test these protocols
> please do.
>
> If nobody objects I'll probably commit it tomorrow.
>
> Thanks,
> Roman


I don't see why you put events in a separate directory, but that doesn't 
matter to me.



Jabber:

> void JabberAccount::slotAddedInfoEventActionActivated ( uint actionId )
> { [...]
> 	if ( actionId == Kopete::AddedInfoEvent::AuthorizeAction )
> 	{ [...] }
>	else if ( actionId == Kopete::AddedInfoEvent::BlockAction )
> 	{ [...]	}
>	else if( actionId == Kopete::AddedInfoEvent::AddContactAction )
> 	{ [...] }

There is two issues.
1) You may want to authorize the contact without adding it (specially if the 
contact was already on the list, but 'blocked'). Or even adding it without 
authorizing it.  ("authorize" here mean allowing the user to see the 
presence)
2) if you go that way you should at least authorize when adding.

I think this is a design problem on the new dialog.
(And I think the problem is the same on MSN)

>  +#include <events/kopeteaddedinfoevent.h?

uh?  :-)




["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]