'Re: [kopete-devel] Prevent creating duplicate accounts'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Prevent creating duplicate accounts
From:       Matt Rogers <mattr () kde ! org>
Date:       2007-11-04 3:58:27
Message-ID: 2862DBFB-0617-413C-910E-A165639E3DBF () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/alternative)]

On Nov 3, 2007, at 1:55 PM, Dennis Nienhüser wrote:

> Hi,
>
> please have a look at the attached patch which prevents adding  
> accounts more
> than once. Currently kopete crashes when doing that, the patch  
> modifies most
> plugins such that a friendly message pops up when creating a duplicate
> account in the add account wizard and proceeding to the next page  
> is not
> possible. Additionally, the accept() method of the wizard does that  
> check
> again (e.g. the Testbed protocol doesn't have the duplicate check).
>
> If there are no objections, I'll check it in.
>
> Regards,
> Dennis

Looks fine to me. Please commit.
--
Matt

[Attachment #7 (unknown)]

<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: \
after-white-space; "><BR><DIV><DIV>On Nov 3, 2007, at 1:55 PM, Dennis Nienhüser \
wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; \
">Hi,</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; \
margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">please have a look at the \
attached patch which prevents adding accounts more<SPAN \
class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">than once. Currently \
kopete crashes when doing that, the patch modifies most<SPAN \
class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">plugins such that a \
friendly message pops up when creating a duplicate<SPAN \
class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">account in the add account \
wizard and proceeding to the next page is not<SPAN class="Apple-converted-space"> \
</SPAN></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; \
margin-left: 0px; ">possible. Additionally, the accept() method of the wizard does \
that check<SPAN class="Apple-converted-space"> </SPAN></DIV><DIV style="margin-top: \
0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">again (e.g. the \
Testbed protocol doesn't have the duplicate check).</DIV><DIV style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; \
"><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; \
margin-left: 0px; ">If there are no objections, I'll check it in.</DIV><DIV \
style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; \
min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; \
margin-bottom: 0px; margin-left: 0px; ">Regards,</DIV><DIV style="margin-top: 0px; \
margin-right: 0px; margin-bottom: 0px; margin-left: 0px; \
">Dennis</DIV></BLOCKQUOTE></DIV><DIV><BR class="khtml-block-placeholder"></DIV>Looks \
fine to me. Please commit.<DIV>--</DIV><DIV><DIV> <SPAN class="Apple-style-span" \
style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); \
font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; \
-khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: \
auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: \
0px; "><SPAN class="Apple-style-span" style="border-collapse: separate; \
border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: \
12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: \
normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: \
none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: \
2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>Matt</DIV><BR \
class="Apple-interchange-newline"></SPAN></SPAN> </DIV><BR></DIV></BODY></HTML>

["PGP.sig" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 