[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Kopete::Message refactoring
From:       Charles Connell <charles () connells ! org>
Date:       2007-04-22 20:29:19
Message-ID: 200704221629.19822.charles () connells ! org
[Download RAW message or body]

On Sunday 22 April 2007 16:21, Michaël Larouche wrote:
> Here as promised my refactoring of Kopete::Message
>
> Just cleaning up the constructor and added some accessor really helped to
> clarify the usage of Kopete::Message :)
>
> instead of:
> Kopete::Message msg( from, to, body, Kopete::Message::Internal, QString(),
> Kopete::Message::TypeAction);
>
> now a Kopete::Message is build like:
> Kopete::Message msg( from, to );
> msg.setPlainBody( body );
> msg.setDirection( Kopete::Message::Internal );
> msg.setType( Kopete::Message::TypeAction );
>
> I left the fromContact and toContact in the constructor, it make some sense
> to me to construct a message with its originator and its recipient.
>
> Also renamed fg(), bg() and related to foregroundColor(), backgroundColor()
>
> Comments before I commit ?
It seems fine
-- 
~Charles Connell
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread]