[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] New class Kopete::Picture
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2005-12-10 18:02:06
Message-ID: 200512101902.14428.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Samedi 10 Décembre 2005 15:50, Michaël Larouche a écrit :
> Le December 8, 2005 19:48, Olivier Goffart a écrit :

> >  - I don't think it's a good idea to use it by pointer.
>
> Yep, I reworked my class to be implicitly shared.

Good.
It was IMO not even required to be shared, because both QString, QPixmap, and 
QImage are shared already. 
Anyway, if it's done, it's ok.

> >  - You probably shouldn't do the conversion immediatly, but only on
> > demand.
>
> I prefer the current way. IMO the "getter" method should be fast, even at
> first call.

I disagree.
Why should this be so fast ?
There is no reason to do all the conversion when Kopete start, and eat all the 
memory, for contact we will not talk with, or we don't need the photo, ...

> >  - QPixmap vs. QImage ?
>
> Yes, QPixmap should be used, because it's faster for display but QImage was
> used in MetaContact instead, so I used QImage.

I'm not really sure here.
We also apply effect to the photo (in the contactlist)




[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]