[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] New class Kopete::Picture
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2005-12-09 0:48:50
Message-ID: 200512090148.54563.ogoffart () tiscalinet ! be
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Vendredi 9 Décembre 2005 00:20, Michaël Larouche a écrit :
> Here is a new libkopete class which represent a picture in Kopete context.
> This is the result of the discussion about my earlier request for a
> metacontact change.
>
> Here it's the attached patch ready to be applied on dev-0.12 SVN and
> forward ported to /trunk.

Nice patch!!!

notes:
 - I don't think it's a good idea to use it by pointer.

 - You probably shouldn't do the conversion immediatly, but only on demand.
    
 - A constructor that take a KABC::Picture is probably a good addition (and 
will be used when syncing from KABC)

 - QPixmap vs. QImage ?


Good work anyway.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]