[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Send Yahoo! Buddy Icon
From:       Thiago Macieira <thiago () kde ! org>
Date:       2005-06-26 16:11:18
Message-ID: 200506261311.18830.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Matt Rogers wrote:
>On Sunday 26 June 2005 09:44 am, Thiago Macieira wrote:
>> Andre Duffeck wrote:
>> >+       void _gotBuddyIconRequestReceiver( int id, char *who );
>> >+       void _uploadBuddyIconProceed( int id, int fd, int error, void
>> > *data );
>> > +       void _buddyIconUploaded( int id, const char *url);
>>
>> You're not allowed to start identifier names with _. Those are
>> reserved.
>
>They're all like that. Do you propose to fix every single callback in
>kyahoo.cpp? Why does it matter now? Why didn't it matter two years ago
> when i started hacking on yahoo and they were still like that? Surely
> identifier names that start with "_" were reserved back then too. I'm
> quite confused.

I thought he was introducing new ones. For whatever reason, his diff 
didn't include context lines, so we didn't get to see what was around 
those lines.

So, ok, for consistency's sake. But one should not use _ or __ at the 
beginning of a symbol name.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t wæs náht, se scieppend þone circolwyrde 
wundorcræftlíge cennede and seo eorðe wæs idel and hit wæs gód.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]