[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Avoiding to test on end()
From:       Thiago Macieira <thiago () kde ! org>
Date:       2005-06-25 16:03:01
Message-ID: 200506251303.01910.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Michel Hermier wrote:
>Hi,
>This patch avoids to loop until reaching end(); while decrementing the
> iterator. The current code is wrong for 2 reasons:
>- decrementing to the begin of the list doesn't return the same value as
> end(); - decrementing to the iterator at the first place, is undefined
> (see http://doc.trolltech.com/3.3/qmapiterator.html#operator-- )
>So this provoke an invalid read (potential crash).
>
>Comments? commit?

I have a comment!

Where's the patch? Didn't you KMail tell you you had forgotten to attach 
something, but the word "patch" was said?

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

5. Swa he géanhwearf tó timbran, and hwonne he cóm, lá! Unix cwæð "Hello, 
World". Ǽfre ǽghwilc wæs glæd and seo woruld wæs fréo.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]