[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] Re: Turning on/off auto spell checking from the
From:       Richard Smith <kde () metafoo ! co ! uk>
Date:       2005-06-13 19:03:54
Message-ID: 200506132003.55076.kde () metafoo ! co ! uk
[Download RAW message or body]

On Monday 13 June 2005 13:05, Matt Rogers wrote:
> On Monday 13 June 2005 03:41 am, Richard Smith wrote:
> > On Monday 13 June 2005 01:46, Matt Rogers wrote:
> > > Ok, here's the patch. Please review and indicate whether or not y'all
> > > would think this would be useful.
> >
> > I think it'd be handy. The patch looks OK to me -- but I personally would
> > prefer if the action were owned by the ChatView class not the
> > KopeteChatWindow class.
>
> I'm not sure I know how I'd do that. The menu entry is done by XMLGUI so
> i'm not sure that the ChatView can own the action, or is that a non-issue
> (as long as the action exists)?

ChatView owns a copy action (which dispatches to the edit widget or to the 
chat view as appropriate) and a close action, and they seem to work, so I 
guess it's a non-issue. As long as they're added to the right 
KActionCollection I would think it'd be fine.
-- 
Thanks,
Richard
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]