[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] decouple tabs from ChatView (the real
From:       Matt Rogers <mattr () kde ! org>
Date:       2005-06-13 11:58:20
Message-ID: 200506130658.23206.mattr () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Monday 13 June 2005 02:31 am, Olivier Goffart wrote:
> Le Lundi 13 Juin 2005 02:54, Matt Rogers a écrit  :
> > Hi,
> >
> > This patch should decouple the implemenation of the tab widget from the
> > ChatView class. Please review.
>
> I haven't reviewed the patch in details, but i trust you. I have no real
> objections.
>
> I just seen that sometimes the signal  updateTabState was called without
> emit.
>
>
> Also, I seen you included the name of function in the patch (the option -p
> of diff)  This make it easier to read.  Did you found a nice way to do that
> ? (because the command i found take more than one line)

I wrote a script to do it. I have one that colors the output on the command 
line for me and another one that removes the color so it's suitable for 
creating patches. 

The one w/o color is attached.

Matt

["svnd-nocolor" (application/x-shellscript)]

#!/bin/sh

exec svn diff --diff-cmd diff -x -up "$@" 

[Attachment #8 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]