[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] decouple tabs from ChatView (the real
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2005-06-13 7:31:52
Message-ID: 200506130931.55772.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Lundi 13 Juin 2005 02:54, Matt Rogers a écrit  :
> Hi,
>
> This patch should decouple the implemenation of the tab widget from the
> ChatView class. Please review.

I haven't reviewed the patch in details, but i trust you. I have no real 
objections.

I just seen that sometimes the signal  updateTabState was called without emit.


Also, I seen you included the name of function in the patch (the option -p of 
diff)  This make it easier to read.  Did you found a nice way to do that ?
(because the command i found take more than one line)

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]