[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] Re: Important:  fix for bug 93671
From:       Richard Smith <kde () metafoo ! co ! uk>
Date:       2005-02-22 20:22:47
Message-ID: 200502222022.47679.kde () metafoo ! co ! uk
[Download RAW message or body]

On Tuesday 22 February 2005 12:03, Jason Keirstead wrote:
> On February 22, 2005 06:12 am, Olivier Goffart wrote:
> > http://bugs.kde.org/show_bug.cgi?id=93671
> >
> > a patch has already been proposed there by jason:
> > http://lists.kde.org/?l=kopete-devel&m=110745701325221&w=2
> > but it was not accepted.
> >
> > Is this patch better ?
> >
> > i added a refcount to the chat session.
>
> Richard and me tossed around some ideas, and I *think* this is along the
> lines of what we were going to do (refcount the session). He was supposed
> to look at it/fix it but I guess did not have time.

Yes, I'm sorry about that. Been a bit caught up with work and preparing to 
move house.

> I would say - if it looks OK, and works OK with both shipping view plugins,
> and valgrind does not report any leaks as a result of the refcount, we
> should commit it

I agree. It looks OK to me.
-- 
Thanks,
Richard
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]