[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] saving photo to disk on each message
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2005-02-17 20:31:43
Message-ID: 200502172131.47645.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Jeudi 17 Février 2005 20:34, Jason Keirstead a écrit :
> On Thursday 17 February 2005 2:38 pm, Olivier Goffart wrote:
> > the photo is already on the disk, but you still copy it.
> >
> > for each message, because KTempFile use randomly generated number.
>
> Oh I see what you are saying. Thisis not really accurate. Most photos
> stored in KABC are stored base64 encoded inside the user's VCard file. So,
> they would need to be decoded and written out to a file to show in the chat
> window regardless.

In my case, most photo are from MSN, and then are on the disk.

> > I've just tested the ichat style, and it doesn't work.
> > Maybe for another reason, but i just see facts.
>
> It works here....

not there. :-)


> > The CPU + hard disk consumption it will take, specially on irc channel if
> > you have several contact with a photo is not neglectible IMO.
>
> It would only store one photo per contatct... 

Per contact * messages.

the KTempFile isn't afaik shared between messages.

> > > The only proper way to do it is to store the message-specific MC's
> > > photo.
> >
> > it's too complex, better to don't have that.
>
> I would disagree. Do it right or not at all.

I would say that the chat window show the contact, in case the contact change 
his photo, the photo should be updated in the whole chat window.

Remember that the photo is from the KAdressBook, it's you which change the 
photo.


IMO both way are fine, and that's why i don't care.

> > I would like you to use the photo property anyway.
> > at least for kde 3.4
>
> The photo property is MSN specific

It's not MSN Specific,  only MSN actually implement it.

> and totally defeats the whole point of the KABC integration.

Probably.


All i can said is that the current way is Not correct.  here are some solution 
i would agree with.
1) use the photo property.  
	- It will work only for MSN contact, 
       +  but it will work with the myself contact.
       +  and that can make sens if we have several contact in the metacontact
		 with different photo   (ok, rare case)

2) the metaContact::photo()  should return something like a KABC::Picture 
which could return both a QString or a QImage.    one could add in this 
Kopete::Picture class a function to convert to a QString, or a QImage.
     - It require some change in Kopete which is probably not good now
    + It's the IMO the best way to do.

But the current way is not acceptable.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]