[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] Re: [PATCH] User-configurable IP for MSN file
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2005-01-09 8:12:11
Message-ID: 200501090912.16051.ogoffart () tiscalinet ! be
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Samedi 8 Janvier 2005 07:14, Anton Markov a écrit :
> Olivier Goffart wrote:

> Ok, here is a patch which adds a "File Transfers" tab to the MSN account
> configuration window. It also adds the necessairy code to use those
> values. The default behavior is still to use the IP of the network
> interface the socket is connected to.

nice.

>
> The GUI is almost identical to Jabber's, except there is no proxy
> configuration, 

ok

> and it works for each account individually, rather than 
> all MSN accounts (I think this makes more sense anyways).

Why does it make more sans.
IMO, this setting should even be for the same for the whole Kopete.
anyway, never mind.

> I have kept the changes to a minimum, and they are fairely straight-
> forward. Most of the patch is actually the changes to the
> msneditaccountui.ui file ('cvs diff' seems to have a problem with making
> efficient patches from XML files). I hope you will find this useful.

I've seen the c++ patch, it looks fine.
but i've not looked yet for the GUI, and i haven't test it.

> One problem is that I can't 100% test the patch, since file transfers
> don't work for me with or without this patch for some reason. However,
> I've looked at the debuging output and ran a packet sniffer, and the
> patch is modifying the IP and Port values in the invitations correctly,
> so it does what it is supposed to. Whether or not there is more to
> making file transfers work through NAT/firewalls I don't know.

that's bad.
Who are you trying to send the file to? another kopete user? an windows user?
Filetransfer are know to not working with gaim.

Why does the transfer fail ?

If the transfer could work it would be better. :-)


Thanks anyway for your patch.
Do you have a cvs account ?


[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]