[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] kdenetwork/kopete/protocols/msn
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2004-04-14 17:09:44
Message-ID: 200404141910.54704.ogoffart () tiscalinet ! be
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Mercredi 14 Avril 2004 17:00, Will Stephenson a écrit :
> CVS commit by wstephens:
>
> This contactlist lookup should always fail because the QString::null
> argument doesn't match any accounts (any more?) 


> --- kdenetwork/kopete/protocols/msn/msnaccount.cpp  #1.74:1.75
> @@ -847,4 +847,5 @@ void MSNAccount::slotContactAdded( const
>                  if ( !contacts()[ handle ] )
>                  {
> +                        // FIXME: findContact() only works if the account
> id is an existing account - see KopeteAccountManager::findAccount() for the
> reason KopeteMetaContact *m =
> KopeteContactList::contactList()->findContact( protocol()->pluginId(),
> QString::null, handle ); if ( m )

This part code is even older than the introduction of accounts in kopete.
Anyway, this sanity check is not verry important, and should never hurt. 
(KopeteAccountManager::findAccount()  even uses internaly 
account->contacts[ handle ] )

So this check can safely be removed IMO.

In general,  findContact is a deprecated method and should noà t even be used 
anymore

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAfYy7z58lY8jWrL0RAkVaAJsGguApnoFDR5TxOMwubvxnUxHnYgCfa+lU
WVfsMxNzsVKxR1jsHGen79M=
=jCQc
-----END PGP SIGNATURE-----
_______________________________________________
Kopete-devel mailing list
Kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread]