[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [Kopete-devel] [Bug 71804] [PATCH] kopete trying to save password
From:       Matt Rogers <matt.rogers () kdemail ! net>
Date:       2004-02-11 23:53:12
Message-ID: 20040211235312.30625.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
      
http://bugs.kde.org/show_bug.cgi?id=71804      
matt.rogers@kdemail.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From matt.rogers@kdemail.net  2004-02-12 00:53 -------
CVS commit by mattr: 

Apply Martijn's patch for bug 71804. Treat null passwords as rememberPassword
 = false.

I assume that lilachaze's new KopetePassword stuff should take care of the rest in HEAD 
when it gets merged back in.

CCMAIL: 71804-done@bugs.kde.org


  M +14 -1     kopeteaccount.cpp   1.78.2.4


--- kdenetwork/kopete/libkopete/kopeteaccount.cpp  #1.78.2.3:1.78.2.4
@@ -357,5 +357,18 @@ QString KopeteAccount::password( bool er
 void KopeteAccount::setPassword( const QString &pass )
 {
-        d->rememberPassword = !pass.isNull();
+        if ( pass.isNull() )
+        {
+                // FIXME: This is a quick workaround for the problem that after Jason
+                //        added the rememberPassword flag he didn't accordingly update
+                //        all plugins to setRememberPassword( false ), so they now
+                //        try to set a null pass when the pass is not to be remembered.
+                //
+                //        After KDE 3.2 this should be fixed by disallowing null
+                //        passwords here and adding said property setter method - Martijn
+                d->password = pass;
+                d->rememberPassword = false;
+                writeConfig( configGroup() );
+                return;
+        }
 
 #if KDE_IS_VERSION( 3, 1, 90 )
_______________________________________________
Kopete-devel mailing list
Kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]