[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] [Bug 63457] SSL support for IRC
From:       Jason Keirstead <jason () keirstead ! org>
Date:       2004-02-06 12:52:00
Message-ID: 200402060852.00983.jason () keirstead ! org
[Download RAW message or body]

On February 06, 2004 8:42 am, Martijn Klingens wrote:
> On Friday 06 February 2004 13:11, Jason Keirstead wrote:
> > Jabber already supports SSL, it's built into it's library.
>
> Would make sense to share the GUI - gives Kopete a more uniform look.

Well,  I think this "gui" should be in KSSLCertificate. 
KSSLCertificate::verifyCertificate() should use the UI server to do all this 
stuff, then it would be in a central place.

HOWEVER, the TCPSlaveBase version of this method has a ton of junk in there 
only related to HTTPS, that I was able to remove.. I am not sure that this 
part of the code could even go into KSSLCertificate.

Anyways, I think what I am going to do is finalize this KSSLSocket ( right 
now, it is *always* in buffered mode) and maybe submit it for inclusion in 
kdelibs, or merge it in with KExtSocket (If I could merge this inside 
KSSLSocket, I wouldn't need nearly as much code). I don't see any reason why 
KDE should not have an SSL stream socket in it's core library.

> > > Would be nice, because I somewhat wonder whether KSSL is thread-safe.
> > > Do you have any knowledge on that?
> >
> > I already removed the QThread stuff.
>
> I'm still curious though :)

I wasn't using it in a multi-threaded manner anyways. I was polling it via a 
separate thread, and I was doing my own mutexing on the data received.

-- 
There's no place like 127.0.0.1

http://www.keirstead.org
_______________________________________________
Kopete-devel mailing list
Kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]