[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] [Bug 63457] SSL support for IRC
From:       Martijn Klingens <klingens () kde ! org>
Date:       2004-02-06 9:55:38
Message-ID: 200402061055.38871.klingens () kde ! org
[Download RAW message or body]

On Thursday 05 February 2004 21:31, Jason Keirstead wrote:
> This isn't really a valid argument; half of KIO has dialogs built in and
> they are all protocols.

KIO *slaves* cannot have a GUI AFAIK, they don't show message boxes either and 
instead leave that up to kio_uiserver.

> I would be heavily against this, due to the fact that I wanted to abstract
> as much as possible the notion of an SSL vs. non SSL connection not only
> from Kopete itself, but libkirc. Right now the SSL code is totally
> contained in ksslsocket.cpp, which inherits from KExtSocket,  To libkirc
> there is no difference at all between SSL and non SSL except creating the
> class.

Hmm, there's also Jabber/SSL. Sounds like libkopete is a better place until 
you move it to libkio in kdelibs itself.

> > - modal(only?) message boxes is(still?) creating potential crash in
> > kopete due to it's design.
>
> The dialogs being modal is an issue *currently*, but it won't be once we
> have KopeteGlobal::UI::mainWidget() ( after this weekend Martijn?? :P ).

Hmm? I'm not sure I follow you here. Modal dialogs are *always* an issue, 
because they start a nested event loop. Thus, whether there's a mainWidget() 
or not, you still can't safely use modal dialogs.

> I realized today that instead of having this thread I could just create my
> own QSocketNotifier for the socket and just totally ignore the KExtSocket
> events. I may do that instead. I will experiment tonight, I may be able to
> get rid of that thread.

Would be nice, because I somewhat wonder whether KSSL is thread-safe. Do you 
have any knowledge on that?

-- 
Martijn
_______________________________________________
Kopete-devel mailing list
Kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]