From kopete-devel Sat Jan 24 19:49:40 2004 From: Stefan Gehn Date: Sat, 24 Jan 2004 19:49:40 +0000 To: kopete-devel Subject: Re: [Kopete-devel] [PATCH] KopeteContact property system + ICQ Message-Id: <200401242049.40290.sgehn () gmx ! net> X-MARC-Message: https://marc.info/?l=kopete-devel&m=107497378813616 On Samstag Januar 24 2004 20:24, Martijn Klingens wrote: > On Saturday 24 January 2004 20:10, Stefan Gehn wrote: > > I doubt it's half the lines it was before :) > > You're close though, especially considering that it's a much smaller patch > for me to read now, only 10.7kb libkopete as opposed to the 28kb monster > you sent yesterday ;) > > I haven't really checked the Oscar diff, that's not my territory, but as > for libkopete, feel free to commit. K, will do. > One gripe against the Oscar part that I just spotted: please consider using > the address book fields for things like email addresses instead of the > properties framework. Basically you should use this new API for things that > do NOT belong in the address book, and I hope that it's obvious that email > address are not amongst those things :) And how does it work? All I have found is KopetePlugin::addAddressBookField() and I fail to see what this has to do with saving a ton of user-information somewhere in the xml. Bye, Stefan aka mETz -- ICQ#51123152 | Moege der Pinguin mit euch sein _______________________________________________ Kopete-devel mailing list Kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel