[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] [PATCH] KopeteContact property system + ICQ
From:       Martijn Klingens <klingens () kde ! org>
Date:       2004-01-24 19:24:31
Message-ID: 200401242024.31581.klingens () kde ! org
[Download RAW message or body]

On Saturday 24 January 2004 20:10, Stefan Gehn wrote:
> I doubt it's half the lines it was before :)

You're close though, especially considering that it's a much smaller patch for 
me to read now, only 10.7kb libkopete as opposed to the 28kb monster you sent 
yesterday ;)

I haven't really checked the Oscar diff, that's not my territory, but as for 
libkopete, feel free to commit.

One gripe against the Oscar part that I just spotted: please consider using 
the address book fields for things like email addresses instead of the 
properties framework. Basically you should use this new API for things that 
do NOT belong in the address book, and I hope that it's obvious that email 
address are not amongst those things :)

-- 
Martijn
_______________________________________________
Kopete-devel mailing list
Kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]