[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] [PATCH] KopeteContact property system + ICQ
From:       Stefan Gehn <sgehn () gmx ! net>
Date:       2004-01-24 17:55:20
Message-ID: 200401241855.20208.sgehn () gmx ! net
[Download RAW message or body]

On Samstag Januar 24 2004 16:51, Martijn Klingens wrote:
>
> - Please commit the alternate colour patch separately or revert it so it
>   won't get committed. This massively degrades the patch's readability BTW
> :(

Alternate colors degrade readability, OMG ;)
SCNR.

> - Please commit the idleTime changes. These are completely independent, are
>   ok, and don't conflict AFAICS.

I won't commit that yet as I think I've seen shortcomings (sec values suddenly 
not changing at all if you just keep showing/hiding the tooltip, but maybe 
I'm seeing ghosts *g*).

>
> - Please commit the formattedName/formattedIdleTime methods.

Seperated from the property patch?

> (In case you don't know how to commit independent hunks of files, please
> let me know. For now I assume you know your CVS well enough to handle that
> alone.)

I don't have a clue how to do that (except diffing the file and changing the 
original source two times with manual copynpaste).

Btw, please try to show up in #kopete more often if time permits (hey, it's 
saturday). I prefer IRC for discussing such changes and post _one_ final 
patch for the absent crowd instead of posting three versions in here.

Bye, Stefan aka mETz
-- 
ICQ#51123152 | Moege der Pinguin mit euch sein
_______________________________________________
Kopete-devel mailing list
Kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]