[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [Kopete-devel] Re: [PATCH] Really change Buddy group on server
From:       Matt Rogers <matt.rogers () kdemail ! net>
Date:       2004-01-01 4:31:20
Message-ID: 200312312231.20796.matt.rogers () kdemail ! net
[Download RAW message or body]

On Wednesday 31 December 2003 05:22 pm, Marcelo Penna Guerra wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Wednesday 31 December 2003 17:16, Matt Rogers wrote:
> > Looks good. However, is there anyway to somehow integrate this with the
> > current SSIModAddDel function we use for buddies, or is it completely
> > different (I haven't looked at the docs).
>
> It's different, very different. SSIModAddDel has three possible procedures:
>
> * Adding a user/group: send edit start, send add contact, send edit end.
> * Removing user/group: just a remove packet
> * Changing item (probably works for renaming, I don't really know): just a
> change packet.
>
> Now, as you can see on my patch, to change the buddy group, you need to:
>
> 1. Send edit start
> 2. Send remove buddy, but without the screenname or TLVs
> 3. Send add buddy with screenname and TLVs, with new group ID
> 4. Send change packet for the group, with a TLV with the buddy ID
> 5. Send edit end
>
> Maybe I can adapt the code so it'll work with a serie of SSIModAddDel, but
> I'm not sure if it's a good idea to do it so close to the release, as it
> can break other things.
>
> Penna

hmm, ok, it does what we need for now. Please commit.

Matt
_______________________________________________
Kopete-devel mailing list
Kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]