[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] Libkopete advice needed
From:       Will Stephenson <william.stephenson () ncl ! ac ! uk>
Date:       2003-09-15 11:06:47
[Download RAW message or body]

On Monday 15 September 2003 11:52, Olivier Goffart wrote:
> Will wrote:
> > KABC data is currently written to the XML when Kopete quits, but the real
> > implementation will write whenever KABC data changes, so that other apps
> > can make use of it immediately.  The common point in the code is
> > KopeteMetaContact::addContact( KopeteContact * ), so I am writing to kabc
> > here.
>
> ohoh. here i remember old discution about the save to contactlist.
>
> I don't like the current way of "serializing"
> actualy used with the API  KopeteContact::serialize() and
> KopeteProtocol::deserializeContact()
> called when loading and saving the contctlist.
>
> my idea is more something like the current pluginData stuff
> QString KopeteContact::field(QString key)
> KopeteContact::setField(QString key, QString value)
> which can be completed maybe with a enum { addToKAB , dontAdd} flag.
>
> this anyway require deep changes.

That's another matter, I think.  But it would be quite nice if it enabled us 
to get rid of FooProtocol::deserializeContact().


> > 1) Add a 'bool newContact' flag to the KopeteContact(), KMC::addContact()
> >   code path so that I have an indication which case it is.
>
> like martijn said: an enum
> { LoadedFromConfig , AddedToContactList , Temporary, ... }

I'm going to do it this way, then.

Will
-- 
Will Stephenson
IRC: Bille

_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]