[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [Kopete-devel] kdenonbeta/kopete/protocols/winpopup
From:       Martijn Klingens <klingens () kde ! org>
Date:       2003-07-14 20:58:49
[Download RAW message or body]

CVS commit by mklingens:

Slightly modified patch from

CCMAIL: =?utf-8?q?André Somers?= <andre@kflog.org>

to make Kopete compile for him.

Thanks for reporting!

PS: Please use 'cvs diff -u' next time to create unified diffs. Those are
    a bit more readable and more robust when applying than 'normal' diffs.

CCMAIL: kopete-devel@kde.org
CCMAIL: Gav Wood <gav@indigoarchive.net>

kopete-devel/Gav: I'm not sure the string isn't used elsewhere in string
comparisons, but as it's a user-visible string it MUST be i18n()-ed, so
I still made this change. If it breaks semantics (can't test winpopup),
please commit a proper fix, but don't remove the i18n.


  M +4 -3      wpuserinfo.cpp   1.2


--- kdenonbeta/kopete/protocols/winpopup/wpuserinfo.cpp  #1.1:1.2
@@ -48,7 +48,7 @@ WPUserInfo::WPUserInfo( WPContact *conta

         QStringList::Iterator it = theHostDetails.begin();
-        m_mainWidget->sWorkgroup->setText( (*it).isEmpty() ? "N/A" : *it );
-        m_mainWidget->sOS->setText( (*++it).isEmpty() ? "N/A" : *it );
-        m_mainWidget->sServer->setText( (*++it).isEmpty() ? "N/A" : *it );
+        m_mainWidget->sWorkgroup->setText( (*it).isEmpty() ? i18n( "N/A" ) : *it );
+        m_mainWidget->sOS->setText( (*++it).isEmpty() ? i18n( "N/A" ) : *it );
+        m_mainWidget->sServer->setText( (*++it).isEmpty() ? i18n( "N/A" ) : *it );

         connect( this, SIGNAL( closeClicked() ), this, SLOT( slotCloseClicked() ) );


_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]