[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] SMS plugin
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2002-11-03 20:15:40
[Download RAW message or body]

>I wrote a SMS-plugin, which is in CVS now.

>But it won't work yet, I need some tips on free sms-services on the web. So 
>if anyone knows of one please mail me.
>
>The plugin also needs an icon, so if anyone feels like painting one, your are 
>more than welcome.

thanks for your begin of plugin.
I think you should wait to have the "sms-service" to begin to work.. 
then you can do directly an optimized code

some remarques about your code.

   
I saw you put the status to Offline...
I don't like the offline status here, but i don't know which use.
if offline, it disapears when we hide offline contact
other opignon?


SMSProtocol::slotStartChat()
where this method is called? i don't think it is used

QPtrList<KopeteContact> SMSContact::theContacts;
what is this???

KActionCollection *SMSContact::customContextMenuActions()
if there are no action here, just return 0L
and then no need to implement this function


void SMSContact::slotCloseHistoryDialog()
void SMSContact::slotHistoryDialogClosing()
That's verry ugly. these two slots should be one

void SMSContact::slotSendFile()
the default implementation isn't sufficient?


void SMSContact::slotUnloading()
we need to add a way to standarise this in libkopete


and at last the size of preferences and the addcontact page are bad for me, i 
see nothing
_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]