[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] Small fix.
From:       Zack Rusin <zackrat () att ! net>
Date:       2002-07-12 17:52:48
[Download RAW message or body]

On Friday 12 July 2002 10:26, Martijn Klingens wrote:
> Add my test account (msntest@martijn.homeip.net) or my normal account
> (msn@martijn.homeip.net). Note that I'm at work now and not online
> with Kopete.

Cool, thanks :)

> Looking at the diff I see at least two issues:
>
> 1. You are changing the indentation from tabs to spaces. Please
> don't, because nothing is worse than two mixed indentations in the
> same file. (For new files feel free to use spaces, as long as there's
> a vim modeline describing it ;-)

That reminds me to add a function to kde-emacs that would parse the 
"//vim: whatever:" thingys and change Emacs indention accordingly. 

> 2. You are not appending the length of the message to the arguments.
> Hmm, that seems to be a bug in Henrik's code. Instead of calculating
> the length inside sendMessage he does it before. That's also why it's
> QCString then, because unicode characters have a length 1 in QString
> (they are a single char), but length 2 or more in QCString (they are
> more than one byte). All places in the code that use the body
> argument need to use a fixed length calculation inside sendMessage,
> not outside. Is that somewhat understandable if you haven't bothered
> with all the unicode stuff before? ;-)

Point well taken, didn't even notice that. Will fix it later today.

Zack

-- 
Gates' Law: Every 18 months, the speed of software halves.

_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]