[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] AutoAway plugin: update xautolock?
From:       Martijn Klingens <klingens () kde ! org>
Date:       2002-06-26 18:47:15
[Download RAW message or body]

On Wednesday 26 June 2002 20:41, Martijn Klingens wrote:
> There should be a KopeteProtocol::isAway() call to handle that (or better,
> KopeteProtocol::status(), returning the same ContactStatus enum that the
> similar call in KopeteContact also returns). The bug is that that method
> doesn't exist. Patches welcome ;-)

Thinking about this again, and reading Hendrik's mail I think this is all a 
more grave design issue.

Shouldn't 'away' be a status *only* of Kopete as whole? Why would you go away 
with one protocol but not with another?

I think the solution is to change the KopeteProtocol::setAway() call into 
KopeteProtocol::setStatus( OnlineStatus s, QString msg = QString::null );

with

enum OnlineStatus { Offline, Online, Away, Unknown };

and a call

Kopete::setStatus( OnlineStatus s, QString msg = QString::null );

The handling of away messages and all GUI for it is done in libkopete for the 
global away and the local away is removed from the GUI. It can be kept, but 
in that case it should reuse the global away message or not use an away 
message at all.

How does that sound?

(Oh, and no, I don't have time to volunteer, I'm just thinking about the 
design here...)

Martijn

_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]