'Re: [Kopete-devel] Hiding window on close instead of Quit revisited'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] Hiding window on close instead of Quit revisited
From:       Henrik Johnson <hpj () globecom ! se>
Date:       2002-06-25 12:54:34
[Download RAW message or body]

You're way is definately better than mine (More of a Qt only hacker 
myself actually). I still think the messagebox is good for newbies which 
might otherwise think they were offline, more advanced users will off 
course turn it off on the first chance so it isn't much in the way there 
either. It's commited to the CVS now anyway.

/Mauritz
Underscore AB

Martijn Klingens wrote:

>On Tuesday 25 June 2002 10:58, Henrik Johnson wrote:
>  
>
>>Ok, I've managed to get a patch into ksystemtray interface to make it
>>emit a signal when it quits instead of only closing the window (Which is
>>still does due to compatibility issues). Attached is a patch to kopete
>>to use this fascilitate to hide instead of quit on close. Obviously this
>>will only work on a fairly recent KDE HEAD CVS, and has the ifdefs to
>>make sure this is the case (Otherwise the old behaviour is preserved).
>>Does anyone have any objections to me committing this?
>>    
>>
>
>Most of the patch looks fine, but one thing I wonder about:
>
>  
>
>>+       if (!config->readBoolEntry("hideOnCloseInfo",false)) {
>>+               KMessageBox::information(this,i18n("<qt>Closing the main
>>window will keep kopete running in the system tray. Use Quit from the File
>>menu to quit the application?</qt>"),i18n("Docking in system tray"));
>>+               config->writeEntry("hideOnCloseInfo",true);
>>+               config->sync();
>>+       }
>>    
>>
>
>Why that messagebox? Sounds a bit intrusive to me.
>
>Also, if I understand the KMessageBox API correctly you can let KMessageBox 
>the 'don't show this again' stuff handle itself by providing a 
>dontShowAgainName parameter to the messagebox, like
>
>KMessageBox::information( this, "text", "caption", "hideOnCloseInfo" );
>
>If you insist on the message box, then please do it like that. That would be 
>fine with me.
>
>  
>

[Attachment #3 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <title></title>
</head>
<body>
You're way is definately better than mine (More of a Qt only hacker myself
actually). I still think the messagebox is good for newbies which might otherwise
think they were offline, more advanced users will off course turn it off
on the first chance so it isn't much in the way there either. It's commited
to the CVS now anyway.<br>
<br>
/Mauritz<br>
Underscore AB<br>
<br>
Martijn Klingens wrote:<br>
<blockquote type="cite" cite="mid200206251116.14565.klingens@kde.org">
  <pre wrap="">On Tuesday 25 June 2002 10:58, Henrik Johnson wrote:
  </pre>
  <blockquote type="cite">
    <pre wrap="">Ok, I've managed to get a patch into ksystemtray interface to make it
emit a signal when it quits instead of only closing the window (Which is
still does due to compatibility issues). Attached is a patch to kopete
to use this fascilitate to hide instead of quit on close. Obviously this
will only work on a fairly recent KDE HEAD CVS, and has the ifdefs to
make sure this is the case (Otherwise the old behaviour is preserved).
Does anyone have any objections to me committing this?
    </pre>
  </blockquote>
  <pre wrap=""><!---->
Most of the patch looks fine, but one thing I wonder about:

  </pre>
  <blockquote type="cite">
    <pre wrap="">+       if (!config-&gt;readBoolEntry("hideOnCloseInfo",false)) {
+               KMessageBox::information(this,i18n("&lt;qt&gt;Closing the main
window will keep kopete running in the system tray. Use Quit from the File
menu to quit the application?&lt;/qt&gt;"),i18n("Docking in system tray"));
+               config-&gt;writeEntry("hideOnCloseInfo",true);
+               config-&gt;sync();
+       }
    </pre>
  </blockquote>
  <pre wrap=""><!---->
Why that messagebox? Sounds a bit intrusive to me.

Also, if I understand the KMessageBox API correctly you can let KMessageBox 
the 'don't show this again' stuff handle itself by providing a 
dontShowAgainName parameter to the messagebox, like

KMessageBox::information( this, "text", "caption", "hideOnCloseInfo" );

If you insist on the message box, then please do it like that. That would be 
fine with me.

  </pre>
</blockquote>
<br>
</body>
</html>

_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 