[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] quit from systray
From:       Martijn Klingens <klingens () kde ! org>
Date:       2002-04-11 7:58:27
[Download RAW message or body]

On Thursday 11 April 2002 01:12, Andres Krapf wrote:
> when i say
>
> /*
>  * The parent's implementation forces 2 menuitems on the right click menu:
>  * Restore/Minimize
>  * Quit, which doesn't work for us since it's connected to slot
> KopeteWindow::close()
>  * So we just leave an empty menu with a titlebar
>  */
>
> i mean that i'm leaving it empty -  for now - (if i let KSystemTray have
> it's way, it'll include the nasty Quit menuitem).

Yes I know what you meant. I understood that code. And it's not the way I'd 
like it to see, because you're basically working around kdelibs. The idea 
behind open source is that you try to fix it where you _should_ and consider 
the libs a white box that can actually be touched. Workarounds at the 
application level IMHO belong more the the closed source world.

> after that, you just use it normally, and populate the menu in KopeteWindow
> with all the stuff you need. i even added a real working Quit there.

Sure. But again, you did so by working around the libs instead of using them - 
that's what I don't like.

> by the way, is there a reason for renaming contextMenu() from KSystemTray
> to getContextMenu() ? wouldn't it be nicer if we kept the same name ?

Yes. There are more getXxxx style methods in Kopete and I'd like to get rid of 
those, because it's highly inconsistent in Qt/KDE. Feel free to commit a 
patch that changes just that. I'd like to wait for a solution for the systray 
problem. When I'm home tonight I'll see if my cross-post to core-devel 
resulted in something useful.

Martijn

_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]