[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: Review Request 129132: Change text to "+" on Add Identitiy QPushbutton
From: Peter Simonsson <peter.simonsson () gmail ! com>
Date: 2016-10-09 13:17:20
Message-ID: 20161009131720.14549.48034 () mimi ! kde ! org
[Download RAW message or body]
--===============3951779291326982395==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 9, 2016, 12:15 p.m., Peter Simonsson wrote:
> > What is this supposed to fix? Seems to mostly break things here...
>
> Nilesh Kokane wrote:
> The Pushbutton should atleast have a text/icon to indicate as to what it does. But that \
> wasn't a case.
Then something is wrong with your installation cause the button has an icon already.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129132/#review99873
-----------------------------------------------------------
On Oct. 9, 2016, 11:53 a.m., Nilesh Kokane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129132/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2016, 11:53 a.m.)
>
>
> Review request for Konversation and Peter Simonsson.
>
>
> Repository: konversation
>
>
> Description
> -------
>
> ^^
>
>
> Diffs
> -----
>
> src/identitydialog.ui 68e255c
>
> Diff: https://git.reviewboard.kde.org/r/129132/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Nilesh Kokane
>
>
--===============3951779291326982395==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129132/">https://git.reviewboard.kde.org/r/129132/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 9th, 2016, 12:15 p.m. UTC, <b>Peter Simonsson</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">What is this supposed to fix? \
Seems to mostly break things here...</p></pre> </blockquote>
<p>On October 9th, 2016, 12:57 p.m. UTC, <b>Nilesh Kokane</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The Pushbutton should atleast \
have a text/icon to indicate as to what it does. But that wasn't a case.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Then something is wrong with your \
installation cause the button has an icon already.</p></pre> <br />
<p>- Peter</p>
<br />
<p>On October 9th, 2016, 11:53 a.m. UTC, Nilesh Kokane wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konversation and Peter Simonsson.</div>
<div>By Nilesh Kokane.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2016, 11:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">^^</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Done</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/identitydialog.ui <span style="color: grey">(68e255c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129132/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3951779291326982395==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic