[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: Review Request 119256: Use more portable routines for byte swapping
From: Peter Simonsson <peter.simonsson () gmail ! com>
Date: 2016-09-14 16:10:40
Message-ID: 20160914161040.18200.88206 () mimi ! kde ! org
[Download RAW message or body]
--===============5303313861863500758==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 7, 2016, 2:34 p.m., Peter Simonsson wrote:
> > Ship It!
Applied to master
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119256/#review98976
-----------------------------------------------------------
On July 14, 2014, 8:18 p.m., Vadim Zhukov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119256/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 8:18 p.m.)
>
>
> Review request for Konversation and Bernd Buschinski.
>
>
> Repository: konversation
>
>
> Description
> -------
>
> Konversation uses insane construction for byte-swapping routines. Given that it already uses \
> sockets, it can use htonl() instead of trying bswap32() unconditionally (which is likely to \
> be wrong on big-endian archs anyway). htonl() could be found on almost all *nix and also on \
> Windows, and it's defined in POSIX.1. Despite of the name, it operates not on "long" but on \
> 32-bit integers.
> The given patch allows to compile Konversation on OpenBSD and should not break other OSes.
>
> Please note that I don't have commit rights in KDE repos, so, if this patch will be accepted, \
> someone will have to commit it on his own. Thanks.
>
> Diffs
> -----
>
> src/dcc/transfer.cpp 4485490
> src/dcc/transferrecv.cpp bf61f88
> src/dcc/transfersend.cpp 398191e
>
> Diff: https://git.reviewboard.kde.org/r/119256/diff/
>
>
> Testing
> -------
>
> OpenBSD/i386-CURRENT
>
>
> Thanks,
>
> Vadim Zhukov
>
>
--===============5303313861863500758==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119256/">https://git.reviewboard.kde.org/r/119256/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 7th, 2016, 2:34 p.m. UTC, <b>Peter Simonsson</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Applied to master</p></pre> <br \
/>
<p>- Peter</p>
<br />
<p>On July 14th, 2014, 8:18 p.m. UTC, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konversation and Bernd Buschinski.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated July 14, 2014, 8:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Konversation \
uses insane construction for byte-swapping routines. Given that it already uses sockets, it can \
use htonl() instead of trying bswap32() unconditionally (which is likely to be wrong on \
big-endian archs anyway). htonl() could be found on almost all *nix and also on Windows, and \
it's defined in POSIX.1. Despite of the name, it operates not on "long" but on 32-bit \
integers.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The given patch allows to compile Konversation on OpenBSD and \
should not break other OSes.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Please note that I don't have commit rights in \
KDE repos, so, if this patch will be accepted, someone will have to commit it on his own. \
Thanks.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">OpenBSD/i386-CURRENT</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dcc/transfer.cpp <span style="color: grey">(4485490)</span></li>
<li>src/dcc/transferrecv.cpp <span style="color: grey">(bf61f88)</span></li>
<li>src/dcc/transfersend.cpp <span style="color: grey">(398191e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119256/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5303313861863500758==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic