[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: Review Request 128222: Improve konversation support on OSX
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-09-07 9:04:54
Message-ID: 20160907090454.5566.53265 () mimi ! kde ! org
[Download RAW message or body]
--===============8458627550087384898==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128222/#review98967
-----------------------------------------------------------
Given I don't use Konversation on Mac, it would be nice if the maintainer could tell \
if that is ok.
- Christoph Cullmann
On June 17, 2016, 10:35 a.m., Cristian Oneț wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128222/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 10:35 a.m.)
>
>
> Review request for Konversation and Christoph Cullmann.
>
>
> Repository: konversation
>
>
> Description
> -------
>
> Including cstdlib is necessary to fix the build otherwise std::abs can't be found.
> The rest of the build system changes allow the creation of a self contained \
> application bundle with high dpi support and proper application icons.
>
> Diffs
> -----
>
> CMakeLists.txt 2d7af35
> data/CMakeLists.txt 9873dd4
> data/MacOSXBundleInfo.plist.in PRE-CREATION
> data/konversation.qrc PRE-CREATION
> src/CMakeLists.txt f808bb9
> src/main.cpp 144254e
> src/viewer/viewcontainer.cpp ff20e6c
>
> Diff: https://git.reviewboard.kde.org/r/128222/diff/
>
>
> Testing
> -------
>
> Successfully using konversation on OSX.
>
>
> Thanks,
>
> Cristian Oneț
>
>
--===============8458627550087384898==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128222/">https://git.reviewboard.kde.org/r/128222/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Given \
I don't use Konversation on Mac, it would be nice if the maintainer could tell if \
that is ok.</p></pre> <br />
<p>- Christoph Cullmann</p>
<br />
<p>On June 17th, 2016, 10:35 a.m. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konversation and Christoph Cullmann.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated June 17, 2016, 10:35 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Including cstdlib is necessary to fix the build \
otherwise std::abs can't be found. The rest of the build system changes allow the \
creation of a self contained application bundle with high dpi support and proper \
application icons.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Successfully using konversation on OSX.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2d7af35)</span></li>
<li>data/CMakeLists.txt <span style="color: grey">(9873dd4)</span></li>
<li>data/MacOSXBundleInfo.plist.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>data/konversation.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(f808bb9)</span></li>
<li>src/main.cpp <span style="color: grey">(144254e)</span></li>
<li>src/viewer/viewcontainer.cpp <span style="color: grey">(ff20e6c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128222/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8458627550087384898==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic