[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: [Konversation-devel] Review Request 109588: Handle multiple identities with the same name
From: José Millán Soto <fid () gpul ! org>
Date: 2013-03-20 8:45:19
Message-ID: 20130320084519.21428.27585 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 19, 2013, 8:32 p.m., Eike Hein wrote:
> > src/application.cpp, line 474
> > <http://git.reviewboard.kde.org/r/109588/diff/1-2/?file=120400#file120400line474>
> >
> > You're no longer checking for -1 here, which means the at() in the next line is \
> > going to crash if IdentityId isn't at least 0. This couldn't happen without \
> > someone manually editing the config file, but people sometimes do ...
> > What you could do though is just change the default to 0 and drop the else case, \
> > because if I'm thinking right, the first list entry is always going to be the \
> > default identity (it's created by the Preferences constructor and the UI doesn't \
> > allow it to be deleted, and since the identities are written out and read in in \
> > list order, it'll still be the first list entry after every store+load cycle).
In the new version of the patch, 0 is used as default and uint is used instead of \
int.
- José
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109588/#review29511
-----------------------------------------------------------
On March 20, 2013, 8:45 a.m., José Millán Soto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109588/
> -----------------------------------------------------------
>
> (Updated March 20, 2013, 8:45 a.m.)
>
>
> Review request for Konversation and Eike Hein.
>
>
> Description
> -------
>
> Correct handling of multiple identities with the same name
>
> - Identity id is used between ServerGroup dialog and Identity dialog
> - Save order is using to store the Identity of a ServerGroup
>
>
> This addresses bug 311300.
> https://bugs.kde.org/show_bug.cgi?id=311300
>
>
> Diffs
> -----
>
> src/application.cpp 71e0f1f
> src/irc/servergroupdialog.cpp 75655b3
>
> Diff: http://git.reviewboard.kde.org/r/109588/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> José Millán Soto
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109588/">http://git.reviewboard.kde.org/r/109588/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 19th, 2013, 8:32 p.m. UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109588/diff/1-2/?file=120400#file120400line474" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/application.cpp</a> <span style="font-weight: normal;">
(Diff revisions 1 - 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Application::readOptions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">474</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">identityPos</span> \
<span class="o"><</span> <span class="n">Preferences</span><span \
class="o">::</span><span class="n">identityList</span><span class="p">().</span><span \
class="n">count</span><span class="p">())</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're no longer \
checking for -1 here, which means the at() in the next line is going to crash if \
IdentityId isn't at least 0. This couldn't happen without someone manually \
editing the config file, but people sometimes do ...
What you could do though is just change the default to 0 and drop the else case, \
because if I'm thinking right, the first list entry is always going to be the \
default identity (it's created by the Preferences constructor and the UI \
doesn't allow it to be deleted, and since the identities are written out and read \
in in list order, it'll still be the first list entry after every store+load \
cycle).</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the new \
version of the patch, 0 is used as default and uint is used instead of int.</pre> <br \
/>
<p>- José</p>
<br />
<p>On March 20th, 2013, 8:45 a.m. UTC, José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konversation and Eike Hein.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated March 20, 2013, 8:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Correct handling of multiple identities with the same name
- Identity id is used between ServerGroup dialog and Identity dialog
- Save order is using to store the Identity of a ServerGroup</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=311300">311300</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(71e0f1f)</span></li>
<li>src/irc/servergroupdialog.cpp <span style="color: grey">(75655b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109588/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Konversation-devel mailing list
Konversation-devel@kde.org
https://mail.kde.org/mailman/listinfo/konversation-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic