[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: [Konversation-devel] Review Request: Make dependency on kdepim
From: "Peter Simonsson" <peter.simonsson () gmail ! com>
Date: 2012-01-04 15:36:34
Message-ID: 20120104153634.11778.92645 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103551/#review9533
-----------------------------------------------------------
Ship it!
Looks good to me
- Peter Simonsson
On Dec. 27, 2011, 12:04 a.m., Thomas Capricelli wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103551/
> -----------------------------------------------------------
> =
> (Updated Dec. 27, 2011, 12:04 a.m.)
> =
> =
> Review request for Konversation.
> =
> =
> Description
> -------
> =
> For people outthere like me that do not use KDE, the dependency on kdepim=
is a very huge one. We would very happily make the tradeoff of NOT being a=
ble to link nicknames to kde addressbook.
> =
> I guess you see the points, depending on kdepim brings two big problems
> * installation/compilation : depending on kdepim brings half of kde packa=
ges, kdepim package and hence ugliness such as nepomuk/akonadi.
> * at runtime, starting konversation, by the magic of dbus and KDE spaghet=
ti runtime dependencies, it starts lot of unrelated KDE stuff daemons that =
takes both cpu and ram. I know this arg is denied by KDE zealot, but i stan=
d on it.
> =
> So I did it. This patch allows compilation without kdepim. I've tried to =
keep the patch as minimal as possible of course.
> =
> I'm always on irc/freenode as 'orzel', and i'll be on #konversation for t=
he next days.
> Also, I do have commit rights on KDE (not sure about konversation proper,=
i did no follow the git migration very closely)
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt c8df038 =
> src/CMakeLists.txt a7ba9f4 =
> src/application.cpp 038b403 =
> src/irc/nick.cpp 298eafb =
> src/irc/nickinfo.h 20b8ef1 =
> src/irc/nickinfo.cpp e768d0d =
> src/irc/nicksonline.h fbdd2cd =
> src/irc/nicksonline.cpp 8c9a4b1 =
> src/irc/outputfilter.cpp a7701e7 =
> src/irc/query.h 3685a53 =
> src/irc/query.cpp 1a432d4 =
> src/irc/server.h 775cb7c =
> src/irc/server.cpp 111131a =
> src/irc/serverison.h 4500564 =
> src/irc/serverison.cpp f737b51 =
> src/konsolepanel.cpp 14b32cc =
> src/main.cpp f2c7a22 =
> src/mainwindow.cpp 112dd39 =
> src/viewer/irccontextmenus.h 40756d1 =
> src/viewer/irccontextmenus.cpp b735843 =
> =
> Diff: http://git.reviewboard.kde.org/r/103551/diff/diff
> =
> =
> Testing
> -------
> =
> cmake with kdepim installed and with kdepim not installed
> compiles tested with kdepim not installed: compiles, link and work fine
> =
> =
> Thanks,
> =
> Thomas Capricelli
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103551/">http://git.reviewboard.kde.org/r/103551/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me</pre> \
<br />
<p>- Peter</p>
<br />
<p>On December 27th, 2011, 12:04 a.m., Thomas Capricelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konversation.</div>
<div>By Thomas Capricelli.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2011, 12:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For people outthere like me that do not use KDE, the dependency on \
kdepim is a very huge one. We would very happily make the tradeoff of NOT being able \
to link nicknames to kde addressbook.
I guess you see the points, depending on kdepim brings two big problems
* installation/compilation : depending on kdepim brings half of kde packages, kdepim \
package and hence ugliness such as nepomuk/akonadi.
* at runtime, starting konversation, by the magic of dbus and KDE spaghetti runtime \
dependencies, it starts lot of unrelated KDE stuff daemons that takes both cpu and \
ram. I know this arg is denied by KDE zealot, but i stand on it.
So I did it. This patch allows compilation without kdepim. I've tried to keep the \
patch as minimal as possible of course.
I'm always on irc/freenode as 'orzel', and i'll be on #konversation \
for the next days. Also, I do have commit rights on KDE (not sure about konversation \
proper, i did no follow the git migration very closely)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">cmake with kdepim installed and with kdepim not installed compiles \
tested with kdepim not installed: compiles, link and work fine</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c8df038)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a7ba9f4)</span></li>
<li>src/application.cpp <span style="color: grey">(038b403)</span></li>
<li>src/irc/nick.cpp <span style="color: grey">(298eafb)</span></li>
<li>src/irc/nickinfo.h <span style="color: grey">(20b8ef1)</span></li>
<li>src/irc/nickinfo.cpp <span style="color: grey">(e768d0d)</span></li>
<li>src/irc/nicksonline.h <span style="color: grey">(fbdd2cd)</span></li>
<li>src/irc/nicksonline.cpp <span style="color: grey">(8c9a4b1)</span></li>
<li>src/irc/outputfilter.cpp <span style="color: grey">(a7701e7)</span></li>
<li>src/irc/query.h <span style="color: grey">(3685a53)</span></li>
<li>src/irc/query.cpp <span style="color: grey">(1a432d4)</span></li>
<li>src/irc/server.h <span style="color: grey">(775cb7c)</span></li>
<li>src/irc/server.cpp <span style="color: grey">(111131a)</span></li>
<li>src/irc/serverison.h <span style="color: grey">(4500564)</span></li>
<li>src/irc/serverison.cpp <span style="color: grey">(f737b51)</span></li>
<li>src/konsolepanel.cpp <span style="color: grey">(14b32cc)</span></li>
<li>src/main.cpp <span style="color: grey">(f2c7a22)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(112dd39)</span></li>
<li>src/viewer/irccontextmenus.h <span style="color: grey">(40756d1)</span></li>
<li>src/viewer/irccontextmenus.cpp <span style="color: grey">(b735843)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103551/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Konversation-devel mailing list
Konversation-devel@kde.org
https://mail.kde.org/mailman/listinfo/konversation-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic