[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129914: [terminalDisplay] Abort calculating geometry for invalid rect
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2017-02-06 19:18:50
Message-ID: 20170206191850.23155.43207 () mimi ! kde ! org
[Download RAW message or body]
--===============3371845999954307570==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Фев. 5, 2017, 8:37 преди обяд, Anthony Fieroni wrote:
> > We can add the guard in updateImageSize (before makeImage) to prevent any calls \
> > to paint an invalid rect or guard stay only in resizeEvent ?
I will push it as is to Applications/16.12, we can correct it on master anyway.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129914/#review102397
-----------------------------------------------------------
On Фев. 4, 2017, 9:57 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129914/
> -----------------------------------------------------------
>
> (Updated Фев. 4, 2017, 9:57 след обяд)
>
>
> Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> Reflect in Kate Konsole part see https://git.reviewboard.kde.org/r/129903/
>
>
> Diffs
> -----
>
> src/TerminalDisplay.cpp dd911779
>
> Diff: https://git.reviewboard.kde.org/r/129914/diff/
>
>
> Testing
> -------
>
> Yup
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============3371845999954307570==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129914/">https://git.reviewboard.kde.org/r/129914/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Февруари 5th, 2017, 8:37 преди \
обяд EET, <b>Anthony Fieroni</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">We can add the guard in \
updateImageSize (before makeImage) to prevent any calls to paint an invalid rect or \
guard stay only in resizeEvent ?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
will push it as is to Applications/16.12, we can correct it on master \
anyway.</p></pre> <br />
<p>- Anthony</p>
<br />
<p>On Февруари 4th, 2017, 9:57 след обяд EET, Anthony Fieroni \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl \
Sandsmark.</div> <div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Фев. 4, 2017, 9:57 след обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Reflect in Kate Konsole part see \
https://git.reviewboard.kde.org/r/129903/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yup</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/TerminalDisplay.cpp <span style="color: grey">(dd911779)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129914/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3371845999954307570==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic