[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129214: Added possibility to give default dir on Part instantiation
From: Sven Fischer <sven () leiderfischer ! de>
Date: 2017-02-03 17:17:51
Message-ID: 20170203171751.23300.7007 () mimi ! kde ! org
[Download RAW message or body]
--===============8833868546154301123==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129214/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 5:17 nachm.)
Status
------
This change has been discarded.
Review request for Konsole.
Repository: konsole
Description
-------
On konsole KPart instantiation, the QVariantList is evaluated for a
default directory to change to. The Part honors the profile setting "Use
same directory...". If it is not set, the directory is ignored.
Simplified the argument parsing
Beautified the source by using C++11 iteration and QVariantMap
Diffs
-----
src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d
Diff: https://git.reviewboard.kde.org/r/129214/diff/
Testing
-------
Built a new version of yakuake against this konsolepart.so. Worked perfectly.
Thanks,
Sven Fischer
--===============8833868546154301123==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129214/">https://git.reviewboard.kde.org/r/129214/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Sven Fischer.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2017, 5:17 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On konsole KPart instantiation, the QVariantList is evaluated for a \
default directory to change to. The Part honors the profile setting "Use same \
directory...". If it is not set, the directory is ignored.
Simplified the argument parsing
Beautified the source by using C++11 iteration and QVariantMap</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built a new version of yakuake against this \
konsolepart.so. Worked perfectly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Part.cpp <span style="color: \
grey">(7968176f2b977f391b44dc36a9df9597b27aff2d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129214/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8833868546154301123==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic