[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 128396: Improvements to file matching
From: Martin Tobias Holmedahl Sandsmark <martin.sandsmark () kde ! org>
Date: 2017-01-29 14:09:21
Message-ID: 20170129140921.28168.52799 () mimi ! kde ! org
[Download RAW message or body]
--===============5073864622071643251==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128396/
-----------------------------------------------------------
(Updated Jan. 29, 2017, 2:09 p.m.)
Review request for Konsole and Kurt Hindenburg.
Changes
-------
Instead of creating a new QDir and QFileInfo for every match, cache the current files \
with a QSet to quickly look up the filenames.
Also rebased on top of master again.
Repository: konsole
Description
-------
Include glob patterns that are either complete filenames or prefixes instead of just \
suffixes, also handle filenames with spaces, as `ls` has started to show them \
(wrapped in '').
Diffs (updated)
-----
src/Filter.h e9a31cde
src/Filter.cpp 7c0ec3ad
Diff: https://git.reviewboard.kde.org/r/128396/diff/
Testing
-------
A lot. KRegexEditor, massif, QElapsedTimer, etc.
Thanks,
Martin Tobias Holmedahl Sandsmark
--===============5073864622071643251==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128396/">https://git.reviewboard.kde.org/r/128396/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2017, 2:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Instead of creating a new QDir and QFileInfo for every \
match, cache the current files with a QSet to quickly look up the filenames.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also rebased on top of master again.</p></pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Include glob patterns that are either complete \
filenames or prefixes instead of just suffixes, also handle filenames with spaces, as \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">ls</code> has started to show them (wrapped \
in '').</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A lot. KRegexEditor, massif, QElapsedTimer, \
etc.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/Filter.h <span style="color: grey">(e9a31cde)</span></li>
<li>src/Filter.cpp <span style="color: grey">(7c0ec3ad)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128396/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5073864622071643251==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic