From konsole-devel Fri Jan 27 14:06:55 2017 From: Kurt Hindenburg Date: Fri, 27 Jan 2017 14:06:55 +0000 To: konsole-devel Subject: Re: Review Request 129677: Pre process the -e custom command argument Message-Id: <20170127140655.28168.39891 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=148552602001827 --===============9065825838730449553== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 21, 2017, 4:24 p.m., Kurt Hindenburg wrote: > > looks fine to me - how much testing did you do? do you need me to commit this for you? - Kurt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129677/#review102165 ----------------------------------------------------------- On Dec. 20, 2016, 2:13 p.m., Maximiliano Curia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129677/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 2:13 p.m.) > > > Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark. > > > Repository: konsole > > > Description > ------- > > Special case parsing of -e, to avoid parsing parameters intended for the > command to be executed. > > > Diffs > ----- > > src/Application.h 8987d789b8b0789592c41ae1b0f4538f5229b64f > src/Application.cpp 6256e08ccc9d57f052790550ca8f20ef3bac1716 > src/main.cpp 26d3da990b6aee564c0c9a237a56a65b1d372508 > > Diff: https://git.reviewboard.kde.org/r/129677/diff/ > > > Testing > ------- > > It works for me. > > > Thanks, > > Maximiliano Curia > > --===============9065825838730449553== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129677/

On January 21st, 2017, 4:24 p.m. UTC, Kurt Hindenburg wrote:
looks fine to me - how much testing did you do?

do you need me to commit this for you?

- Kurt

On December 20th, 2016, 2:13 p.m. UTC, Maximiliano Curia wrote:

Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.

By Maximiliano Curia.

Updated Dec. 20, 2016, 2:13 p.m.

Repository: konsole

Description

Special case parsing of -e, to avoid parsing parameters intended for the
command to be executed.

Testing

It works for me.

Diffs

src/Application.h (8987d789b8b0789592c41ae1b0f4538f5229b64f)
src/Application.cpp (6256e08ccc9d57f052790550ca8f20ef3bac1716)
src/main.cpp (26d3da990b6aee564c0c9a237a56a65b1d372508)

View Diff

--===============9065825838730449553==--