From konsole-devel Thu Jan 26 01:36:29 2017 From: Kurt Hindenburg Date: Thu, 26 Jan 2017 01:36:29 +0000 To: konsole-devel Subject: Re: Review Request 129886: Fix --new-tab with multiple processes enabled Message-Id: <20170126013629.28168.79010 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=148539459327545 --===============6840007765456987010== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129886/#review102242 ----------------------------------------------------------- Ship it! looks good - do you want to remove my comment I committed earlier? - Kurt Hindenburg On Jan. 25, 2017, 9:27 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129886/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 9:27 p.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Bugs: 373440 > http://bugs.kde.org/show_bug.cgi?id=373440 > > > Repository: konsole > > > Description > ------- > > Make sure we re-use the process if the user wants a new tab. > > > Diffs > ----- > > src/main.cpp f4bb5af3 > > Diff: https://git.reviewboard.kde.org/r/129886/diff/ > > > Testing > ------- > > It now opens a new tab in the existing window correctly. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============6840007765456987010== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129886/

Ship it!

looks good - do you want to remove my comment I committed earlier?

- Kurt Hindenburg

On January 25th, 2017, 9:27 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Konsole and Kurt Hindenburg.

By Martin Tobias Holmedahl Sandsmark.

Updated Jan. 25, 2017, 9:27 p.m.

Bugs: 373440

Repository: konsole

Description

Make sure we re-use the process if the user wants a new tab.

Testing

It now opens a new tab in the existing window correctly.

Diffs

src/main.cpp (f4bb5af3)

View Diff

--===============6840007765456987010==--