From konsole-devel Sun Jan 22 20:47:16 2017 From: Kurt Hindenburg Date: Sun, 22 Jan 2017 20:47:16 +0000 To: konsole-devel Subject: Re: Review Request 129874: Limit ourselves to 3 combining characters Message-Id: <20170122204716.19722.28816 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=148511804115720 --===============8704545526591554990== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129874/#review102191 ----------------------------------------------------------- Ship it! good - want to throw the .py into tests folder? - Kurt Hindenburg On Jan. 22, 2017, 8:02 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129874/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2017, 8:02 p.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Repository: konsole > > > Description > ------- > > This seems to be the maximum in all the test files I've been trying. Without this we get an issue with too many combining characters where Konsole will eventually just hang. > > > Diffs > ----- > > src/Screen.cpp 0b3124a5 > tests/combining.py PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129874/diff/ > > > Testing > ------- > > Test case which breaks Konsole without this patch added. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============8704545526591554990== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129874/

Ship it!

good - want to throw the .py into tests folder?

- Kurt Hindenburg

On January 22nd, 2017, 8:02 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Konsole and Kurt Hindenburg.

By Martin Tobias Holmedahl Sandsmark.

Updated Jan. 22, 2017, 8:02 p.m.

Repository: konsole

Description

This seems to be the maximum in all the test files I've been trying. Without this we get an issue with too many combining characters where Konsole will eventually just hang.

Testing

Test case which breaks Konsole without this patch added.

Diffs

src/Screen.cpp (0b3124a5)
tests/combining.py (PRE-CREATION)

View Diff

--===============8704545526591554990==--