From konsole-devel Sat Jan 21 15:34:29 2017 From: Kurt Hindenburg Date: Sat, 21 Jan 2017 15:34:29 +0000 To: konsole-devel Subject: Re: Review Request 129840: Fix word boundary detection with combining characters Message-Id: <20170121153429.31352.29604 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=148501287330318 --===============2709752193491430608== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129840/#review102163 ----------------------------------------------------------- Ship it! Ship It! - Kurt Hindenburg On Jan. 15, 2017, 3:46 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129840/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 3:46 p.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Repository: konsole > > > Description > ------- > > Without this it doesn't correctly detect word boundaries e. g. in arabic. > > > Diffs > ----- > > src/TerminalDisplay.cpp 26b5012d > > Diff: https://git.reviewboard.kde.org/r/129840/diff/ > > > Testing > ------- > > Test with e. g. «?????????». > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============2709752193491430608== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129840/

Ship it! 

Ship It!

- Kurt Hindenburg


On January 15th, 2017, 3:46 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Konsole and Kurt Hindenburg.
By Martin Tobias Holmedahl Sandsmark.

Updated Jan. 15, 2017, 3:46 p.m.

Repository: konsole

Description 

Without this it doesn't correctly detect word boundaries e. g. in arabic.

Testing 

Test with e. g. «?????????».

Diffs

  • src/TerminalDisplay.cpp (26b5012d)

View Diff
--===============2709752193491430608==--