--===============7611954267673489945== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129841/#review102162 ----------------------------------------------------------- Ship it! Ship It! - Kurt Hindenburg On Jan. 15, 2017, 4:01 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129841/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 4:01 p.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Repository: konsole > > > Description > ------- > > For our own sanity we (falsely) assume that all surrogate characters are double width, otherwise we have to go back and reflow the line... > > This makes it work better with emojis in vim at least. > > > Diffs > ----- > > src/Screen.cpp d674017b > src/konsole_wcwidth.cpp 39c23076 > > Diff: https://git.reviewboard.kde.org/r/129841/diff/ > > > Testing > ------- > > It handles ???? (U+1F4A9) properly in vim. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============7611954267673489945== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129841/

Ship it!

Ship It!

- Kurt Hindenburg

On January 15th, 2017, 4:01 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Konsole and Kurt Hindenburg.

By Martin Tobias Holmedahl Sandsmark.

Updated Jan. 15, 2017, 4:01 p.m.

Repository: konsole

Description

For our own sanity we (falsely) assume that all surrogate characters are double width, otherwise we have to go back and reflow the line...

This makes it work better with emojis in vim at least.

Testing

It handles ???? (U+1F4A9) properly in vim.

Diffs

src/Screen.cpp (d674017b)
src/konsole_wcwidth.cpp (39c23076)

View Diff

--===============7611954267673489945==--