From konsole-devel Sat Jan 21 15:22:00 2017 From: Kurt Hindenburg Date: Sat, 21 Jan 2017 15:22:00 +0000 To: konsole-devel Subject: Re: Review Request 129837: Don't include newlines in selection if trimming is on Message-Id: <20170121152200.31352.24811 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=148501212730226 --===============2494739880114141418== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129837/#review102161 ----------------------------------------------------------- Ship it! Ship It! - Kurt Hindenburg On Jan. 15, 2017, 1:16 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129837/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 1:16 p.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Bugs: 199381 > http://bugs.kde.org/show_bug.cgi?id=199381 > > > Repository: konsole > > > Description > ------- > > If the user has selected to strip whitespace at the end of selected lines, strip out newlines as well. > > Should fix the case described in https://git.reviewboard.kde.org/r/129786/ > > > Diffs > ----- > > src/Screen.cpp d674017b > > Diff: https://git.reviewboard.kde.org/r/129837/diff/ > > > Testing > ------- > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============2494739880114141418== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129837/

Ship it! 

Ship It!

- Kurt Hindenburg


On January 15th, 2017, 1:16 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Konsole and Kurt Hindenburg.
By Martin Tobias Holmedahl Sandsmark.

Updated Jan. 15, 2017, 1:16 p.m.

Bugs: 199381
Repository: konsole

Description 

If the user has selected to strip whitespace at the end of selected lines, strip out newlines as well.


Should fix the case described in https://git.reviewboard.kde.org/r/129786/

Diffs

  • src/Screen.cpp (d674017b)

View Diff
--===============2494739880114141418==--