[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: Review Request 129677: Pre process the -e custom command argument
From:       Maximiliano Curia <maxy () debian ! org>
Date:       2016-12-20 14:08:45
Message-ID: 20161220140845.6043.39599 () mimi ! kde ! org
[Download RAW message or body]

--===============7028759935725704412==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129677/
-----------------------------------------------------------

(Updated Dec. 20, 2016, 2:08 p.m.)


Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Tweak getCustomCommand so QCommandLineParser deals with an empty -e


Repository: konsole


Description
-------

Special case parsing of -e, to avoid parsing parameters intended for the
command to be executed.


Diffs (updated)
-----

  src/Application.h 8987d789b8b0789592c41ae1b0f4538f5229b64f 
  src/Application.cpp 6256e08ccc9d57f052790550ca8f20ef3bac1716 
  src/main.cpp 26d3da990b6aee564c0c9a237a56a65b1d372508 

Diff: https://git.reviewboard.kde.org/r/129677/diff/


Testing
-------

It works for me.


Thanks,

Maximiliano Curia


--===============7028759935725704412==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129677/">https://git.reviewboard.kde.org/r/129677/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl \
Sandsmark.</div> <div>By Maximiliano Curia.</div>


<p style="color: grey;"><i>Updated Dec. 20, 2016, 2:08 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tweak getCustomCommand so QCommandLineParser deals \
with an empty -e</p></pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Special case parsing of -e, to avoid parsing parameters intended for the \
command to be executed.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It works for me.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Application.h <span style="color: \
grey">(8987d789b8b0789592c41ae1b0f4538f5229b64f)</span></li>

 <li>src/Application.cpp <span style="color: \
grey">(6256e08ccc9d57f052790550ca8f20ef3bac1716)</span></li>

 <li>src/main.cpp <span style="color: \
grey">(26d3da990b6aee564c0c9a237a56a65b1d372508)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129677/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7028759935725704412==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic